-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: testing self referencing tables in foreign key stress tests #16216
Merged
shlomi-noach
merged 3 commits into
vitessio:main
from
planetscale:ci-fk-stress-self-reference
Jun 19, 2024
Merged
CI: testing self referencing tables in foreign key stress tests #16216
shlomi-noach
merged 3 commits into
vitessio:main
from
planetscale:ci-fk-stress-self-reference
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Component: Build/CI
Type: CI/Build
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
Component: VTGate
labels
Jun 18, 2024
shlomi-noach
requested review from
harshit-gangal,
systay and
frouioui
as code owners
June 18, 2024 06:54
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jun 18, 2024
shlomi-noach
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jun 18, 2024
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16216 +/- ##
==========================================
+ Coverage 68.55% 68.56% +0.01%
==========================================
Files 1544 1544
Lines 197895 197895
==========================================
+ Hits 135658 135678 +20
+ Misses 62237 62217 -20 ☔ View full report in Codecov by Sentry. |
frouioui
approved these changes
Jun 18, 2024
dbussink
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Build/CI
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
Component: VTGate
Type: CI/Build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a self referencing table to the foreign key stress tests. The self referencing table goes through mostly the same tests as other tables, but note:
ON DELETE CASCADE
norON UPDATE CASCADE
as these create a multitude of unexpected scenarios where collected metrics cannot be validated.Related Issue(s)
Checklist
Deployment Notes