Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the bootstrap dependency on the Docker images we ship #16339

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Remove the bootstrap dependency on the Docker images we ship #16339

merged 10 commits into from
Jul 8, 2024

Commits on Jul 8, 2024

  1. Remove bootstrap dependency for the lite image 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    17e9453 View commit details
    Browse the repository at this point in the history

  2. Remove the local docker image 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    7dcf64b View commit details
    Browse the repository at this point in the history

  3. Remove bootstrap dependency for the vttestserver image 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1ab2da3 View commit details
    Browse the repository at this point in the history

  4. add dry-run docker build for all general images 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0a4826e View commit details
    Browse the repository at this point in the history

  5. login only when we need to push the images 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    aefb694 View commit details
    Browse the repository at this point in the history

  6. Merge all the worklow that builds into a single one 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6c1158d View commit details
    Browse the repository at this point in the history

  7. Fix variable name in debug log 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    72d9cd5 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
    @frouioui @deepthi
    frouioui and deepthi authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    af52626 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
    @frouioui
    frouioui authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c5ae3ee View commit details
    Browse the repository at this point in the history

  10. Apply review suggestions 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e99c1a7 View commit details
    Browse the repository at this point in the history