Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] planner: Handle ORDER BY inside derived tables (#16353) #16360

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jul 9, 2024

Description

This is a backport of #16353

@vitess-bot vitess-bot bot added Backport This is a backport Component: Query Serving Merge Conflict Skip CI Skip CI actions from running Type: Bug labels Jul 9, 2024
Copy link
Contributor Author

vitess-bot bot commented Jul 9, 2024

Hello @systay, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 16360 -R vitessio/vitess
git reset --hard origin/release-20.0
git cherry-pick -m 1 eb29999a3f4730b2ebe2e0abe1d1996ce2d861d9

Copy link
Contributor Author

vitess-bot bot commented Jul 9, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v20.0.1 milestone Jul 9, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
@systay systay force-pushed the backport-16353-to-release-20.0 branch from 804095a to c2d9d4c Compare July 10, 2024 07:33
@systay systay removed Skip CI Skip CI actions from running Merge Conflict labels Jul 10, 2024
@systay systay marked this pull request as ready for review July 10, 2024 07:33
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (795a7e5) to head (c236886).

Files Patch % Lines
go/vt/vtgate/planbuilder/operators/route.go 86.66% 4 Missing ⚠️
...vt/vtgate/planbuilder/operators/queryprojection.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16360      +/-   ##
================================================
+ Coverage         68.66%   68.67%   +0.01%     
================================================
  Files              1541     1541              
  Lines            197830   197827       -3     
================================================
+ Hits             135833   135855      +22     
+ Misses            61997    61972      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui merged commit c1b4e4f into release-20.0 Jul 10, 2024
181 checks passed
@frouioui frouioui deleted the backport-16353-to-release-20.0 branch July 10, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants