-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sequence table next value acl permission to writer role #16509
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16509 +/- ##
==========================================
- Coverage 68.75% 68.74% -0.01%
==========================================
Files 1556 1556
Lines 199699 199704 +5
==========================================
- Hits 137300 137295 -5
- Misses 62399 62409 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Description
For Select and Union queries, Vitess only checks for read permission on vttablet.
This PR changes to check on write permission for the Next Value of sequence table calls.
Related Issue(s)
Checklist
Deployment Notes