Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the name of the vitess-tester repository #16917

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Change the name of the vitess-tester repository #16917

merged 3 commits into from
Oct 22, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Oct 8, 2024 •
edited
Loading

Description

We recently changed the name of the vitess-tester repository to vt. This PR reflects the change needed in vitess.

https://github.com/vitessio/vt

@frouioui
Change the name of the vitess-tester repository
bb493fd 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 8, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 8, 2024
@frouioui frouioui added Backport to: release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 Type: Internal Cleanup Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 8, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 8, 2024
@frouioui
Copy link
Member Author

frouioui commented Oct 8, 2024 •
edited
Loading

This PR is blocked by vitessio/vt#36, once it is merged we should update the SHA used when downloading vt.

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.15%. Comparing base (d651a42) to head (f133942).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16917   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files        1571     1571           
  Lines      251836   251836           
=======================================
+ Hits       169110   169129   +19     
+ Misses      82726    82707   -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitess-bot vitess-bot mentioned this pull request Oct 14, 2024
Closed
35 tasks
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Oct 21, 2024
Closed
28 tasks
@frouioui
Use newer commit to install vt
44b0aa4 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Merge remote-tracking branch 'origin/main' into change-vitess-tester-…
f133942 
…repo-name

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit 0e22a3e into vitessio:main Oct 22, 2024
98 checks passed
@frouioui frouioui deleted the change-vitess-tester-repo-name branch October 22, 2024 03:57
This was referenced Oct 22, 2024
Merged
Merged
Merged
@vitess-bot vitess-bot bot mentioned this pull request Oct 22, 2024
Merged
rohit-nayak-ps pushed a commit that referenced this pull request Oct 29, 2024
@vitess-bot @rohit-nayak-ps
Change the name of the vitess-tester repository (#16917)
ad106d9
frouioui pushed a commit that referenced this pull request Oct 29, 2024
@vitess-bot
[release-21.0] Change the name of the vitess-tester repository (#16917)…
4d55532 
… (#17030)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
frouioui added a commit that referenced this pull request Nov 5, 2024
@frouioui
Change the name of the vitess-tester repository (#16917)
ef9bbb2 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Nov 5, 2024
@frouioui
Change the name of the vitess-tester repository (#16917)
16d2f11 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Nov 5, 2024
@frouioui
Change the name of the vitess-tester repository (#16917)
1dd5d3e 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Nov 11, 2024
@vitess-bot @frouioui
[release-19.0] Change the name of the vitess-tester repository (#16917)…
4909bb2 
… (#17028)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
frouioui added a commit that referenced this pull request Nov 11, 2024
@vitess-bot @frouioui
[release-20.0] Change the name of the vitess-tester repository (#16917)…
968a3c3 
… (#17029)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
frouioui added a commit that referenced this pull request Nov 11, 2024
@vitess-bot @frouioui
[release-18.0] Change the name of the vitess-tester repository (#16917)…
7bc0ef7 
… (#17027)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 Component: Build/CI Type: Internal Cleanup
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @systay @GuptaManan100