[Direct PR] [release-21.0] Revert Errant GTID detection in vttablets

[GuptaManan100]

Description

In light of the issue found in #17018, I think it is prudent to revert the changes made in #16833 and not get them into release-21.0. We can fix it main properly but I don't think it should be put into release-21.

We will fix this in main and may decide to back port the change to a patch release of v21 once we're certain it works on intended. For now, we've decided to revert this change.

Related Issue(s)

• Bug Report: Incorrect errant GTID detection because of how semi-sync replication works #17018

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 11.42857% with 31 lines in your changes missing coverage. Please review.

Project coverage is 67.21%. Comparing base (3fce8ca) to head (b5c1bd0).
Report is 10 commits behind head on release-21.0.

Files with missing lines	Patch %	Lines
go/vt/vttablet/tabletmanager/restore.go	0.00%	21 Missing ⚠️
go/vt/vttablet/tabletmanager/tm_init.go	28.57%	10 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-21.0   #17019      +/-   ##
================================================
+ Coverage         67.13%   67.21%   +0.08%     
================================================
  Files              1570     1570              
  Lines            251255   251247       -8     
================================================
+ Hits             168671   168880     +209     
+ Misses            82584    82367     -217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.