Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-21.0] Release of v21.0.0-RC2 #17022

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

rohit-nayak-ps
Copy link
Contributor

Includes the release notes and release commit for the v21.0.0-RC2 release. Once this PR is merged, we will be able to tag v21.0.0-RC2 on the merge commit.

Copy link
Contributor

vitess-bot bot commented Oct 21, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 21, 2024
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Oct 21, 2024
28 tasks
@github-actions github-actions bot added this to the v21.0.0 milestone Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (5f957b2) to head (706348b).
Report is 1 commits behind head on release-21.0.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-21.0   #17022   +/-   ##
=============================================
  Coverage         67.23%   67.24%           
=============================================
  Files              1570     1570           
  Lines            251264   251264           
=============================================
+ Hits             168935   168952   +17     
+ Misses            82329    82312   -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepthi deepthi removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Oct 22, 2024
@rohit-nayak-ps rohit-nayak-ps force-pushed the release-21.0-create-release-6 branch from 444776f to 1847030 Compare October 22, 2024 17:14
@frouioui frouioui force-pushed the release-21.0-create-release-6 branch from 1847030 to 4469b97 Compare October 22, 2024 21:11
This commit was made automatically by the vitess-releaser tool.

See https://github.com/vitessio/vitess-releaser

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
This commit was made automatically by the vitess-releaser tool.

See https://github.com/vitessio/vitess-releaser

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@frouioui frouioui force-pushed the release-21.0-create-release-6 branch from 4469b97 to 706348b Compare October 23, 2024 04:31
@rohit-nayak-ps rohit-nayak-ps merged commit 54fa8d8 into release-21.0 Oct 23, 2024
190 of 192 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the release-21.0-create-release-6 branch October 23, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants