-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP explicitly skip-include_stats in ReloadSchema
#17101
WIP explicitly skip-include_stats in ReloadSchema
#17101
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17101 +/- ##
==========================================
- Coverage 67.15% 67.15% -0.01%
==========================================
Files 1571 1571
Lines 252250 252251 +1
==========================================
- Hits 169409 169401 -8
- Misses 82841 82850 +9 ☔ View full report in Codecov by Sentry. |
Put on ice. #17118 is hopefully good for now. |
Description
Experimental: we add the ability to skip include stats in
ReloadSchema
by introducingSkipIncludeStats
field inReloadSchemaRequest
. The only one to actually skip stats is the Online DDL executor.Related Issue(s)
Checklist
Deployment Notes