-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify Ubuntu 24.04 for all jobs #17278
Specify Ubuntu 24.04 for all jobs #17278
Conversation
This ensures we're on a consistent version and not a floating one where we depend on whenever GitHub upgrades. I believe this was incorrectly done in the past. I had pinned it on 22.04 in the past exactly because of that reason. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17278 +/- ##
==========================================
+ Coverage 67.37% 67.42% +0.04%
==========================================
Files 1573 1573
Lines 253113 253128 +15
==========================================
+ Hits 170538 170659 +121
+ Misses 82575 82469 -106 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
aecb454
to
f002c89
Compare
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
f002c89
to
2382ef2
Compare
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This ensures we're on a consistent version and not a floating one where we depend on whenever GitHub upgrades. I believe this was incorrectly done in the past. I had pinned it on 22.04 in the past exactly because of that reason.
Related Issue(s)
This was done incorrectly in #16714 which should have used
ubuntu-22.04
and notubuntu-latest
then.Checklist
I have marked this for backporting because we don't want this to start accidentally failing on older release branches either if this gets upgraded. We should stay consistent here.