Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-20.0] Code Freeze for v20.0.4 #17313

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[release-20.0] Code Freeze for v20.0.4 #17313

merged 1 commit into from
Dec 2, 2024

Conversation

vitess-bot
Copy link
Contributor

This Pull Request freezes the branch release-20.0 for v20.0.4

@rohit-nayak-ps
Code Freeze of release-20.0
878faad 
This commit was made automatically by the vitess-releaser tool.

See https://github.com/vitessio/vitess-releaser

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@vitess-bot vitess-bot requested a review from deepthi as a code owner December 2, 2024 16:02
@vitess-bot vitess-bot added Component: General Changes throughout the code base Type: Release labels Dec 2, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 2, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 2, 2024
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 2, 2024
@rohit-nayak-ps rohit-nayak-ps merged commit 7c7d871 into release-20.0 Dec 2, 2024
1 check passed
@rohit-nayak-ps rohit-nayak-ps deleted the release-20.0-code-freeze-2 branch December 2, 2024 16:03
@vitess-bot vitess-bot mentioned this pull request Dec 2, 2024
Closed
28 tasks
@github-actions github-actions bot added this to the v20.0.4 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@frouioui frouioui frouioui approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Release
Projects
None yet
Milestone
v20.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@vitess-bot @frouioui @rohit-nayak-ps