Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Change varbinary to varchar in schemas used in examples folder #17318

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
4 changes: 2 additions & 2 deletions examples/backups/create_commerce_schema.sql
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
create table if not exists product(
sku varbinary(128),
description varbinary(128),
sku varchar(128),
description varchar(128),
price bigint,
primary key(sku)
) ENGINE=InnoDB;
Expand Down
4 changes: 2 additions & 2 deletions examples/backups/create_customer_schema.sql
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
create table if not exists customer(
customer_id bigint not null,
email varbinary(128),
email varchar(128),
primary key(customer_id)
) ENGINE=InnoDB;

create table if not exists corder(
order_id bigint not null,
customer_id bigint,
sku varbinary(128),
sku varchar(128),
price bigint,
primary key(order_id)
) ENGINE=InnoDB;
8 changes: 4 additions & 4 deletions examples/local/create_commerce_schema.sql
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
create table if not exists product(
sku varbinary(128),
description varbinary(128),
sku varchar(128),
description varchar(128),
price bigint,
primary key(sku)
) ENGINE=InnoDB;
create table if not exists customer(
customer_id bigint not null auto_increment,
email varbinary(128),
email varchar(128),
primary key(customer_id)
) ENGINE=InnoDB;
create table if not exists corder(
order_id bigint not null auto_increment,
customer_id bigint,
sku varbinary(128),
sku varchar(128),
price bigint,
primary key(order_id)
) ENGINE=InnoDB;
8 changes: 4 additions & 4 deletions examples/operator/create_commerce_schema.sql
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
create table if not exists product(
sku varbinary(128),
description varbinary(128),
sku varchar(128),
description varchar(128),
price bigint,
primary key(sku)
) ENGINE=InnoDB;
create table if not exists customer(
customer_id bigint not null auto_increment,
email varbinary(128),
email varchar(128),
primary key(customer_id)
) ENGINE=InnoDB;
create table if not exists corder(
order_id bigint not null auto_increment,
customer_id bigint,
sku varbinary(128),
sku varchar(128),
price bigint,
primary key(order_id)
) ENGINE=InnoDB;
6 changes: 3 additions & 3 deletions examples/region_sharding/create_main_schema.sql
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
CREATE TABLE IF NOT EXISTS customer (
id int NOT NULL,
fullname varbinary(256),
nationalid varbinary(256),
country varbinary(256),
fullname varchar(256),
nationalid varchar(256),
country varchar(256),
primary key(id)
);
Loading