-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LookupVindex bug fix: Fix typos from PR 17301 #17423
base: main
Are you sure you want to change the base?
Conversation
…ookupvindex Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17423 +/- ##
==========================================
- Coverage 67.64% 67.62% -0.03%
==========================================
Files 1582 1582
Lines 254000 254000
==========================================
- Hits 171826 171775 -51
- Misses 82174 82225 +51 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rename the files too.
They have already been renamed? to:
|
Ah, sorry! Reviewed on my phone and I didn't see the rename there (might have just gotten cut off so only seeing the first portion of the |
Description
Changing references from "lookup index" to "lookup vindex", which were typos from #17301.
We backport these to the same version the original PR was backported to.
Related Issue(s)
#17301
Checklist
Deployment Notes