Upgrade to Go 1.17

[frouioui]

Description

Bumping the Go version of the project to Go 1.17.

Checklist

• Tests were added or are not required
• Documentation was added or is not required

[deepthi]

It's weird to have two require blocks. Will a go mod tidy clean this up?

[ajm188]

No, this is the "New Way" ™️ in 1.17, specifically:

If a module specifies go 1.17 or higher in its go.mod file, its go.mod file now contains an explicit require directive for every module that provides a transitively-imported package. (In previous versions, the go.mod file typically only included explicit requirements for directly-imported packages.)

Because the number of explicit requirements may be substantially larger in an expanded Go 1.17 go.mod file, the newly-added requirements on indirect dependencies in a go 1.17 module are maintained in a separate require block from the block containing direct dependencies.

[guidoiaquinti]

[frouioui]

Tests are all green after building the new docker bootstrap image. Waiting for tomorrow morning to see the benchmarking results.

[frouioui]

The upgrade presents no significant performance improvement or regression: https://benchmark.vitess.io/compare?r=d10312297ffd33b144d742aba62fe5365c6b5019&c=645f06caf8336f2ab25f8fab101b11776914ed3b

[vmg]

I'm a bit disappointed that the new register allocation engine in the compiler doesn't appear to have a measurable effect in the performance of the whole system. I managed to see some improvements on micro-benchmarks, so it's a bit of a bummer that this is not being propagated to macros.

[deepthi]

The upgrade presents no significant performance improvement or regression: https://benchmark.vitess.io/compare?r=d10312297ffd33b144d742aba62fe5365c6b5019&c=645f06caf8336f2ab25f8fab101b11776914ed3b

Paraphrasing offline conversation with @frouioui:
The benchmark setup was incorrect when it first ran, that has since been fixed and it shows between 3% and 5% improvement depending on metric. The latest results are available at the same link.

[deepthi]

Nice work @frouioui! Thank you for taking this on.