WIP: VStreamer: improve representation of integers in json data types

[rohit-nayak-ps]

Description

The binlog parser in vstreamer uses the github.com/spyzhov/ajson module to decode the value from the binlog image to its json value. However the library only supports a single type Numeric (float64) as a catchall for all numeric types including signed and unsigned integers. Due to this the generated JSON represents integers as floats and the string representation in a vevent can contain decimals or values in a scientific notation. So integers can be stored as floats on the target and larger ints sent with scientific notation in vstream events.

This results in VDiff failures since the json strings stored are different. Also parsing the vevents sent using the VStream API can result in errors if, for example, the json is being parsed by golang. See #8686.

Note: This PR uses a forked version of the library https://github.com/rohit-nayak-ps/ajson that adds Integer and UnsignedInteger data type json Nodes. The Draft PR is pointing to that fork. More work (including more tests, addition of these types to the parsing flow) needs to be done before submitting a PR to upstream repo.

Related Issue(s)

#8686

Checklist

• Should this PR be backported?
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR was closed because it has been stale for 7 days with no activity.

[lisachenko-indriver]

Can we proceed further with this PR? It might fix our issue with broken consistency during replication of big integers as floats inside JSON fields from a source database to Vitess shards /cc @rohit-nayak-ps

[lisachenko-indriver]

Created bug report as well in the ajson library as well, let' see spyzhov/ajson#63, maybe maintainer will merge your changes as a PR.

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

• Is it really necessary to add this flag?
• Flag names should be clear and intuitive (as far as possible)
• Help text should be descriptive.
• Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow should be required, the maintainer team should be notified.

Bug fixes

• There should be at least one unit or end-to-end test.
• The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

• There should be some code comments as to why things are implemented the way they are.

New/Existing features

• Should be documented, either by modifying the existing documentation or creating new documentation.
• New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• vtctl command output order should be stable and awk-able.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from VTop, if used there.

[rohit-nayak-ps]

Closed in favor of #12761