-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs after explicitly allowing bind addressed in servenv #1600
Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -24,7 +25,7 @@ This helps ensure that `mysqld` is automatically restarted after failures. | |||
--config-file string Full path of the config file (with extension) to use. If set, --config-path, --config-type, and --config-name are ignored. | |||
--config-file-not-found-handling ConfigFileNotFoundHandling Behavior when a config file is not found. (Options: error, exit, ignore, warn) (default warn) | |||
--config-name string Name of the config file (without extension) to search for. (default "vtconfig") | |||
--config-path strings Paths to search for config files in. (default [/Users/andrew/dev/vitess]) | |||
--config-path strings Paths to search for config files in. (default [/Users/florentpoinsard/Code/vitess]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh shoot this is fine to merge but can you open an issue for us to fix/anonymize this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #1601
bbd2cdf
to
c100bc7
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
c100bc7
to
f91265a
Compare
@@ -44,7 +44,7 @@ mysqlctl \ | |||
--config-file string Full path of the config file (with extension) to use. If set, --config-path, --config-type, and --config-name are ignored. | |||
--config-file-not-found-handling ConfigFileNotFoundHandling Behavior when a config file is not found. (Options: error, exit, ignore, warn) (default warn) | |||
--config-name string Name of the config file (without extension) to search for. (default "vtconfig") | |||
--config-path strings Paths to search for config files in. (default [/Users/andrew/dev/vtwebsite/vitessio.website/vitess]) | |||
--config-path strings Paths to search for config files in. (default [<WORKDIR>]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
vitessio/vitess#13188
Note: this PR also include a small fix to
./tools/sync_cobradocs.sh
tosed
the modified files in order to make all path anonymous.