Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs after explicitly allowing bind addressed in servenv #1600

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Sep 25, 2023

vitessio/vitess#13188

Note: this PR also include a small fix to ./tools/sync_cobradocs.sh to sed the modified files in order to make all path anonymous.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit f91265a
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/651dfa29fcfb3600083cd4fa
😎 Deploy Preview https://deploy-preview-1600--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -24,7 +25,7 @@ This helps ensure that `mysqld` is automatically restarted after failures.
--config-file string Full path of the config file (with extension) to use. If set, --config-path, --config-type, and --config-name are ignored.
--config-file-not-found-handling ConfigFileNotFoundHandling Behavior when a config file is not found. (Options: error, exit, ignore, warn) (default warn)
--config-name string Name of the config file (without extension) to search for. (default "vtconfig")
--config-path strings Paths to search for config files in. (default [/Users/andrew/dev/vitess])
--config-path strings Paths to search for config files in. (default [/Users/florentpoinsard/Code/vitess])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh shoot this is fine to merge but can you open an issue for us to fix/anonymize this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #1601

@frouioui frouioui force-pushed the gen-docs-for-13188 branch from bbd2cdf to c100bc7 Compare October 4, 2023 18:22
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the gen-docs-for-13188 branch from c100bc7 to f91265a Compare October 4, 2023 23:50
@@ -44,7 +44,7 @@ mysqlctl \
--config-file string Full path of the config file (with extension) to use. If set, --config-path, --config-type, and --config-name are ignored.
--config-file-not-found-handling ConfigFileNotFoundHandling Behavior when a config file is not found. (Options: error, exit, ignore, warn) (default warn)
--config-name string Name of the config file (without extension) to search for. (default "vtconfig")
--config-path strings Paths to search for config files in. (default [/Users/andrew/dev/vtwebsite/vitessio.website/vitess])
--config-path strings Paths to search for config files in. (default [<WORKDIR>])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frouioui frouioui merged commit 34b5c22 into prod Oct 5, 2023
4 checks passed
@frouioui frouioui deleted the gen-docs-for-13188 branch October 5, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants