sync cobradocs #1605
Merged
sync cobradocs #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2023 12:07
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
commented
Sep 27, 2023
| @@ -24,7 +25,7 @@ This helps ensure that `mysqld` is automatically restarted after failures. | |||
| --config-file string Full path of the config file (with extension) to use. If set, --config-path, --config-type, and --config-name are ignored. | |||
| --config-file-not-found-handling ConfigFileNotFoundHandling Behavior when a config file is not found. (Options: error, exit, ignore, warn) (default warn) | |||
| --config-name string Name of the config file (without extension) to search for. (default "vtconfig") | |||
| --config-path strings Paths to search for config files in. (default [/Users/andrew/dev/vitess]) | |||
| --config-path strings Paths to search for config files in. (default [/Users/andrew/dev/vtwebsite/vitessio.website/vitess]) | |||
There was a problem hiding this comment.
unfortunately this is gonna generate some unnecessary churn until i get to #1601 (which i'm working on separately)
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mattlord
approved these changes
Sep 27, 2023
Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
commented
Sep 28, 2023
| @@ -25,7 +25,7 @@ This helps ensure that `mysqld` is automatically restarted after failures. | |||
| --config-file string Full path of the config file (with extension) to use. If set, --config-path, --config-type, and --config-name are ignored. | |||
| --config-file-not-found-handling ConfigFileNotFoundHandling Behavior when a config file is not found. (Options: error, exit, ignore, warn) (default warn) | |||
| --config-name string Name of the config file (without extension) to search for. (default "vtconfig") | |||
| --config-path strings Paths to search for config files in. (default [/Users/andrew/dev/vtwebsite/vitessio.website/vitess]) | |||
| --config-path strings Paths to search for config files in. (default [$WORKDIR]) | |||
There was a problem hiding this comment.
note that the older versions will get this change when we update the release tags (since we currently "sync" to the v17.x.y (and so on for 16 and 15) tag instead of release-17.0
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first half of #1602 (next step is to get this hooked up to some sort of on-push/merge hook from the main codebase side of things)