fix: address review feedback

vitest-dev · Aug 27, 2024 · bf57d53 · bf57d53
1 parent 051c652
commit bf57d53
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/packages/runner/src/run.ts b/packages/runner/src/run.ts
@@ -181,7 +181,7 @@ export async function runTest(test: Test | Custom, runner: VitestRunner): Promis
 
   test.result = {
     state: 'run',
-    startTime: Date.now(),
+    startTime: start,
     retryCount: 0,
   }
   updateTask(test, runner)
@@ -376,7 +376,7 @@ export async function runSuite(suite: Suite, runner: VitestRunner): Promise<void
 
   suite.result = {
     state: 'run',
-    startTime: Date.now(),
+    startTime: start,
   }
 
   updateTask(suite, runner)

diff --git a/test/cli/test/reported-tasks.test.ts b/test/cli/test/reported-tasks.test.ts
@@ -6,7 +6,6 @@ import type { WorkspaceProject } from 'vitest/node'
 import { runVitest } from '../../test-utils'
 import type { TestCase, TestCollection, TestModule } from '../../../packages/vitest/src/node/reporters/reported-tasks'
 
-const now = new Date()
 // const finishedFiles: File[] = []
 const collectedFiles: RunnerTestFile[] = []
 let state: StateManager
@@ -103,7 +102,6 @@ it('correctly reports a passed test', () => {
   expect(diagnostic).toBeDefined()
   expect(diagnostic.heap).toBeGreaterThan(0)
   expect(diagnostic.duration).toBeGreaterThan(0)
-  expect(date(new Date(diagnostic.startTime))).toBe(date(now))
   expect(diagnostic.flaky).toBe(false)
   expect(diagnostic.repeatCount).toBe(0)
   expect(diagnostic.repeatCount).toBe(0)
@@ -150,7 +148,6 @@ it('correctly reports failed test', () => {
   expect(diagnostic).toBeDefined()
   expect(diagnostic.heap).toBeGreaterThan(0)
   expect(diagnostic.duration).toBeGreaterThan(0)
-  expect(date(new Date(diagnostic.startTime))).toBe(date(now))
   expect(diagnostic.flaky).toBe(false)
   expect(diagnostic.repeatCount).toBe(0)
   expect(diagnostic.repeatCount).toBe(0)
@@ -217,10 +214,6 @@ it('correctly passed down metadata', () => {
   expect(meta).toHaveProperty('key', 'value')
 })
 
-function date(time: Date) {
-  return `${time.getDate()}/${time.getMonth() + 1}/${time.getFullYear()}`
-}
-
 function deepFind(children: TestCollection, name: string): TestCase | undefined {
   for (const task of children) {
     if (task.type === 'test') {