fix(cli): forward node wasm flags #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
changed the title
renovate bot
referenced
this pull request
in beeequeue/arm-server
Sep 18, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vitest/coverage-c8](https://github.com/vitest-dev/vitest) | [`0.23.2` -> `0.23.4`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-c8/0.23.2/0.23.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vitest](https://github.com/vitest-dev/vitest) | [`0.23.2` -> `0.23.4`](https://renovatebot.com/diffs/npm/vitest/0.23.2/0.23.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest</summary> ### [`v0.23.4`](https://github.com/vitest-dev/vitest/releases/tag/v0.23.4) [Compare Source](https://github.com/vitest-dev/vitest/compare/v0.23.2...v0.23.4) ##### 🚀 Features - Give helpful message, when using vi.mock - by [@​sheremet-va](https://github.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2047](https://github.com/vitest-dev/vitest/issues/2047) - **benchmark**: Only mode - by [@​Aslemammad](https://github.com/Aslemammad) in [https://github.com/vitest-dev/vitest/issues/2039](https://github.com/vitest-dev/vitest/issues/2039) ##### 🐞 Bug Fixes - Move outputFile to benchmark, allow --reporter for benchmark - by [@​sheremet-va](https://github.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/2037](https://github.com/vitest-dev/vitest/issues/2037) - **cli**: Forward node wasm flags - by [@​Peeterush](https://github.com/Peeterush) in [https://github.com/vitest-dev/vitest/issues/2041](https://github.com/vitest-dev/vitest/issues/2041) - **coverage**: `istanbul-reports` to support `projectRoot` - by [@​AriPerkkio](https://github.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/2051](https://github.com/vitest-dev/vitest/issues/2051) ##### [View changes on GitHub](https://github.com/vitest-dev/vitest/compare/v0.23.3...v0.23.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 11am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BeeeQueue/arm-server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE5Ny4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--experimental-wasm-threads --wasm-atomics-on-non-shared-memoryThese node options cannot be enabled via the
NODE_OPTIONSenvironment variable, only via cli flags. But usingnode --experimental-wasm-threads --wasm-atomics-on-non-shared-memory vitestonly applies them tocli-wrapper, not to any subsequently spawned processes. The proposed change adds them to the list of flags that Vitest forwards to spawned processes.