Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .svelte-kit to eslint ignores #5282

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

fenghan34
Copy link
Contributor

@fenghan34 fenghan34 commented Feb 23, 2024

Description

When I ran the lint command in the Vitest codebase, got the following result. The directory .svelte-kit was generated after runing pnpm test:ci, I thought it might be better to add it to eslint ignore list.

image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 3c43ead
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65d87b3e46c4710008dc3cf7

@sheremet-va sheremet-va merged commit 5bb8b38 into vitest-dev:main Feb 23, 2024
17 of 19 checks passed
@fenghan34 fenghan34 deleted the chore/eslint-ignores branch February 23, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants