Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(browser): make iframe scalable, improve documentation #6257

Merged
merged 21 commits into from
Aug 5, 2024

Conversation

sheremet-va
Copy link
Member

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va requested a review from userquin August 1, 2024 14:33
@sheremet-va
Copy link
Member Author

sheremet-va commented Aug 1, 2024

@userquin I would also love to have https://github.com/user-attachments/assets/29e796ae-6c84-4cf7-8328-b846e3df1f35 in "Running Tests" section - could you help me with that? (need dark mode)

@userquin
Copy link
Member

userquin commented Aug 1, 2024

@sheremet-va
Copy link
Member Author

sheremet-va commented Aug 1, 2024

check this 2 dead links: app.netlify.com/sites/vitest-dev/deploys/66ab9d78d3068b00084d4d00

Fixed just now

@sheremet-va sheremet-va changed the title docs: restructure browser documentation docs: restructure browser mode documentation Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 2209d3c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66b09853b726730008e13698
😎 Deploy Preview https://deploy-preview-6257--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin
Copy link
Member

userquin commented Aug 1, 2024

So, now the only way to access the browser mode page is from the navbar, maybe we can add the link in the left aside. On mobile the browser mode link will be on top right menu and missing from the left menu hamburger button.

(just add the Browser Mode link without expandable children)

@sheremet-va
Copy link
Member Author

So, now the only way to access the browser mode page is from the navbar, maybe we can add the link in the left aside. On mobile the browser mode link will be on top right menu and missing from the left menu hamburger button.

(just add the Browser Mode link without expandable children)

My logic was that it is still displayed in the right hamburger on mobile. Isn't it enough?

@userquin
Copy link
Member

userquin commented Aug 1, 2024

It is fine, no other entries in the navbar present.

FYI: maybe we can remove mastodon, X and discord links from resources navbar menu, already present in the navbar

@sheremet-va sheremet-va changed the title docs: restructure browser mode documentation feat(browser): make iframe scalable, improve documentation Aug 2, 2024
@sheremet-va
Copy link
Member Author

sheremet-va commented Aug 2, 2024

@userquin @JessicaSachs made iframe scalable (similarly to how cypress implements it) - please check when you have time 🙏🏻

Note: I didn't change the viewport reset yet, it's a bit tricky (it won't be changed in this PR)

@sheremet-va
Copy link
Member Author

sheremet-va commented Aug 2, 2024

Oof, I forgot about the "Select a test to run" use case 👀

@userquin
Copy link
Member

userquin commented Aug 2, 2024

Oof, I forgot about the "Select a test to run" use case

from the ui?

@userquin
Copy link
Member

userquin commented Aug 2, 2024

The ui doesn't start, Vitest hangs when running nr test:browser:preview or any other provider.

userquin
userquin previously approved these changes Aug 2, 2024
Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remember to update images for Vitest ui and coverage (6 in total, 3 per theme): /guide/ui.html and /guide/coverage.html#vitest-ui pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants