-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(browser): make iframe scalable, improve documentation #6257
Conversation
@userquin I would also love to have https://github.com/user-attachments/assets/29e796ae-6c84-4cf7-8328-b846e3df1f35 in "Running Tests" section - could you help me with that? (need dark mode) |
check this 2 dead links: https://app.netlify.com/sites/vitest-dev/deploys/66ab9d78d3068b00084d4d00#L358-L359 |
Fixed just now |
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
So, now the only way to access the browser mode page is from the navbar, maybe we can add the link in the left aside. On mobile the browser mode link will be on top right menu and missing from the left menu hamburger button. (just add the |
My logic was that it is still displayed in the right hamburger on mobile. Isn't it enough? |
It is fine, no other entries in the navbar present. FYI: maybe we can remove mastodon, X and discord links from resources navbar menu, already present in the navbar |
33f765a
to
8c3f155
Compare
@userquin @JessicaSachs made iframe scalable (similarly to how cypress implements it) - please check when you have time 🙏🏻 Note: I didn't change the viewport reset yet, it's a bit tricky (it won't be changed in this PR) |
Oof, I forgot about the "Select a test to run" use case 👀 |
from the ui? |
The ui doesn't start, Vitest hangs when running |
f9b3593
to
7cd4f1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remember to update images for Vitest ui and coverage (6 in total, 3 per theme): /guide/ui.html and /guide/coverage.html#vitest-ui pages
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.