Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix edge case in license files bundling #6460

Merged

Conversation

SuperchupuDev
Copy link
Contributor

Description

#6274 removed usage of the caseSensitiveMatch option as tinyglobby didn't have it at the time. It switched to a simple (LICENSE)|(license) matching instead. As you can imagine, this introduced an edge case that made mixed-case license files not match. Thankfully the edge case was never hit. The latest tinyglobby version added this option, so this PR makes usage of it, fixing this edge case.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4abfd13
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66de376b37a5e1000859c0f9
😎 Deploy Preview https://deploy-preview-6460--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit 97773e2 into vitest-dev:main Sep 9, 2024
12 of 16 checks passed
@SuperchupuDev SuperchupuDev deleted the chore/fix-license-globbing branch September 9, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants