Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(coverage): move re-usable parts to base provider #6665

Merged

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Oct 8, 2024

Description

  • Refactors v8 and istanbul coverage providers by moving re-usable logic into base provider
  • Note that we cannot move parts where dependencies of coverage providers are used as we don't want to bring those into vitest package

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a0a677f
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6705595eb75e8d00082559ec
😎 Deploy Preview https://deploy-preview-6665--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio force-pushed the refactor/coverage-shared-base branch from 5f66007 to b71597a Compare October 8, 2024 16:09
@AriPerkkio AriPerkkio force-pushed the refactor/coverage-shared-base branch from b71597a to a0a677f Compare October 8, 2024 16:10
@AriPerkkio AriPerkkio marked this pull request as ready for review October 8, 2024 16:13
@AriPerkkio
Copy link
Member Author

/ecosystem-ci run

@vitest-ecosystem-ci
Copy link

vitest-ecosystem-ci bot commented Oct 8, 2024

📝 Ran ecosystem CI: Open

suite result
aria-live-capture ✅ success
nuxt ❌ failure
nuxt-test-utils ✅ success
elk ✅ success
effect ✅ success
zustand ✅ success
vue ✅ success
vite ✅ success
vitest-vscode ❌ failure
vitest-sonar-reporter ✅ success
vitest-github-actions-reporter ✅ success
vitest-browser-simple ✅ success
vitest-browser-examples ✅ success
vitest-coverage-large ✅ success
vitest-reporters-large ✅ success
vitest-benchmark-large ✅ success

Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-300 LOC 🎉

@AriPerkkio AriPerkkio merged commit 7155cee into vitest-dev:main Oct 11, 2024
17 checks passed
@AriPerkkio AriPerkkio deleted the refactor/coverage-shared-base branch October 11, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants