Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): use /mockServiceWorker.js instead of /__vitest_msw__ #6687

Merged

Conversation

sheremet-va
Copy link
Member

Description

This change allows users to reuse the established Vitest msw worker instead of overriding it

Fixes #6633

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 4907b7c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6708ebfc07ba66000965f61f
😎 Deploy Preview https://deploy-preview-6687--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit 4b2ce07 into vitest-dev:main Oct 11, 2024
17 checks passed
@sheremet-va sheremet-va deleted the fix/browser-msw-service-worker branch October 11, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocks are lost when reruning the tests in browser mode when using MSW
1 participant