-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set resolve.mainFields
and resolve.conditions
for SSR environment
#6896
chore: set resolve.mainFields
and resolve.conditions
for SSR environment
#6896
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@vitest/browser
@vitest/coverage-istanbul
@vitest/expect
@vitest/coverage-v8
@vitest/mocker
@vitest/pretty-format
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vite-node
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm testing Vite 6 in #6867 and had a issue with immutable
package, but fixed after adding this. It looks like it was due to Vitest picking up module
field.
Description
Since vitejs/vite#18395,
ssr.resolve.conditions
/ssr.resolve.mainField
(this does not exist yet, maybe needed?) does not inheritresolve.conditions
/resolve.mainFields
anymore.This PR sets those values by
environments.ssr.resolve.conditions
/environments.ssr.resolve.mainFields
.This PR should fix the ecosystem-ci fail for vite-plugin-react.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.