Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pretty-format): support react 19 #6909

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Nov 15, 2024

Description

I bundled npm:react-is@19.0.0-rc-b01722d5-20241114 to cover React 19 case out of the box.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8dcae90
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6736ad8c65fc900008257ecf
😎 Deploy Preview https://deploy-preview-6909--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa force-pushed the fix-pretty-format-react-19 branch from d27a348 to 093a47a Compare November 15, 2024 02:01
Copy link

pkg-pr-new bot commented Nov 15, 2024

@vitest/browser

pnpm add https://pkg.pr.new/@vitest/browser@6909

@vitest/coverage-istanbul

pnpm add https://pkg.pr.new/@vitest/coverage-istanbul@6909

@vitest/expect

pnpm add https://pkg.pr.new/@vitest/expect@6909

@vitest/coverage-v8

pnpm add https://pkg.pr.new/@vitest/coverage-v8@6909

@vitest/mocker

pnpm add https://pkg.pr.new/@vitest/mocker@6909

@vitest/pretty-format

pnpm add https://pkg.pr.new/@vitest/pretty-format@6909

@vitest/runner

pnpm add https://pkg.pr.new/@vitest/runner@6909

@vitest/snapshot

pnpm add https://pkg.pr.new/@vitest/snapshot@6909

@vitest/spy

pnpm add https://pkg.pr.new/@vitest/spy@6909

@vitest/ui

pnpm add https://pkg.pr.new/@vitest/ui@6909

@vitest/utils

pnpm add https://pkg.pr.new/@vitest/utils@6909

vite-node

pnpm add https://pkg.pr.new/vite-node@6909

@vitest/web-worker

pnpm add https://pkg.pr.new/@vitest/web-worker@6909

vitest

pnpm add https://pkg.pr.new/vitest@6909

@vitest/ws-client

pnpm add https://pkg.pr.new/@vitest/ws-client@6909

commit: 8dcae90

@hi-ogawa hi-ogawa marked this pull request as ready for review November 15, 2024 02:28
@sheremet-va sheremet-va merged commit bd29bcc into vitest-dev:main Nov 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vitest/pretty-format is not compatible with React 19 snapshots
2 participants