Increases the performance of the Bottom bar's Notification dot calcul…

…ations

app/src/main/java/com/vitorpamplona/amethyst/model/Account.kt

@@ -98,7 +98,6 @@ class Account(
     // Observers line up here.
     val live: AccountLiveData = AccountLiveData(this)
     val liveLanguages: AccountLiveData = AccountLiveData(this)
-    val liveLastRead: AccountLiveData = AccountLiveData(this)
     val saveable: AccountLiveData = AccountLiveData(this)
 
     @Immutable
@@ -3113,12 +3112,14 @@ class Account(
         live.invalidateData()
     }
 
-    fun markAsRead(route: String, timestampInSecs: Long) {
+    fun markAsRead(route: String, timestampInSecs: Long): Boolean {
         val lastTime = lastReadPerRoute[route]
-        if (lastTime == null || timestampInSecs > lastTime) {
+        return if (lastTime == null || timestampInSecs > lastTime) {
             lastReadPerRoute = lastReadPerRoute + Pair(route, timestampInSecs)
             saveable.invalidateData()
-            liveLastRead.invalidateData()
+            true
+        } else {
+            false
         }
     }
 

app/src/main/java/com/vitorpamplona/amethyst/ui/navigation/AppBottomBar.kt

@@ -8,7 +8,6 @@ import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.RowScope
 import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.size
-import androidx.compose.foundation.layout.width
 import androidx.compose.foundation.layout.wrapContentHeight
 import androidx.compose.foundation.shape.CircleShape
 import androidx.compose.material3.Divider
@@ -19,11 +18,10 @@ import androidx.compose.material3.NavigationBarItem
 import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.DisposableEffect
-import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.State
+import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.derivedStateOf
 import androidx.compose.runtime.getValue
-import androidx.compose.runtime.livedata.observeAsState
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
 import androidx.compose.runtime.setValue
@@ -38,14 +36,14 @@ import androidx.compose.ui.unit.Dp
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
 import androidx.navigation.NavBackStackEntry
-import com.vitorpamplona.amethyst.model.LocalCache
 import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
 import com.vitorpamplona.amethyst.ui.theme.BottomTopHeight
 import com.vitorpamplona.amethyst.ui.theme.DividerThickness
-import kotlinx.coroutines.Dispatchers
-import kotlinx.coroutines.launch
+import com.vitorpamplona.amethyst.ui.theme.Size0dp
+import com.vitorpamplona.amethyst.ui.theme.Size10dp
+import kotlinx.collections.immutable.persistentListOf
 
-val bottomNavigationItems = listOf(
+val bottomNavigationItems = persistentListOf(
     Route.Home,
     Route.Message,
     Route.Video,
@@ -61,6 +59,9 @@ enum class Keyboard {
 fun keyboardAsState(): State<Keyboard> {
     val keyboardState = remember { mutableStateOf(Keyboard.Closed) }
     val view = LocalView.current
+
+    println("AAA - KeyboardState")
+
     DisposableEffect(view) {
         val onGlobalListener = ViewTreeObserver.OnGlobalLayoutListener {
             val rect = Rect()
@@ -106,9 +107,7 @@ private fun RenderBottomMenu(
         Divider(
             thickness = DividerThickness
         )
-        NavigationBar(
-            tonalElevation = 0.dp
-        ) {
+        NavigationBar(tonalElevation = Size0dp) {
             bottomNavigationItems.forEach { item ->
                 HasNewItemsIcon(item, accountViewModel, navEntryState, nav)
             }
@@ -123,104 +122,46 @@ private fun RowScope.HasNewItemsIcon(
     navEntryState: State<NavBackStackEntry?>,
     nav: (Route, Boolean) -> Unit
 ) {
-    var hasNewItems by remember { mutableStateOf(false) }
-
-    WatchPossibleNotificationChanges(route, accountViewModel) {
-        if (it != hasNewItems) {
-            hasNewItems = it
+    val selected by remember(navEntryState.value) {
+        derivedStateOf {
+            navEntryState.value?.destination?.route?.substringBefore("?") == route.base
         }
     }
 
+    println("AAA HasNewItemsIcon")
+
     val size = remember {
         if ("Home" == route.base) 25.dp else 23.dp
     }
     val iconSize = remember {
         if ("Home" == route.base) 24.dp else 20.dp
     }
 
-    BottomIcon(
-        icon = route.icon,
-        size = size,
-        iconSize = iconSize,
-        base = route.base,
-        hasNewItems = hasNewItems,
-        navEntryState = navEntryState
-    ) { selected ->
-        nav(route, selected)
-    }
-}
-
-@Composable
-fun WatchPossibleNotificationChanges(
-    route: Route,
-    accountViewModel: AccountViewModel,
-    onChange: (Boolean) -> Unit
-) {
-    val accountState by accountViewModel.accountLiveData.observeAsState()
-    val notifState by accountViewModel.accountLastReadLiveData.observeAsState()
-
-    LaunchedEffect(key1 = notifState, key2 = accountState) {
-        launch(Dispatchers.IO) {
-            onChange(route.hasNewItems(accountViewModel.account, emptySet()))
-        }
-    }
-
-    LaunchedEffect(Unit) {
-        launch(Dispatchers.IO) {
-            LocalCache.live.newEventBundles.collect {
-                launch(Dispatchers.IO) {
-                    onChange(route.hasNewItems(accountViewModel.account, it))
-                }
-            }
-        }
-    }
-}
-
-@Composable
-private fun RowScope.BottomIcon(
-    icon: Int,
-    size: Dp,
-    iconSize: Dp,
-    base: String,
-    hasNewItems: Boolean,
-    navEntryState: State<NavBackStackEntry?>,
-    onClick: (Boolean) -> Unit
-) {
-    val selected by remember(navEntryState.value) {
-        derivedStateOf {
-            navEntryState.value?.destination?.route?.substringBefore("?") == base
-        }
-    }
-
-    NavigationIcon(icon, size, iconSize, selected, hasNewItems, onClick)
-}
-
-@Composable
-private fun RowScope.NavigationIcon(
-    icon: Int,
-    size: Dp,
-    iconSize: Dp,
-    selected: Boolean,
-    hasNewItems: Boolean,
-    onClick: (Boolean) -> Unit
-) {
     NavigationBarItem(
         icon = {
+            val hasNewItems = accountViewModel.notificationDots.hasNewItems[route]?.collectAsState()
+
             NotifiableIcon(
-                icon,
+                route.icon,
                 size,
                 iconSize,
                 selected,
                 hasNewItems
             )
         },
         selected = selected,
-        onClick = { onClick(selected) }
+        onClick = { nav(route, selected) }
     )
 }
 
 @Composable
-private fun NotifiableIcon(icon: Int, size: Dp, iconSize: Dp, selected: Boolean, hasNewItems: Boolean) {
+private fun NotifiableIcon(
+    icon: Int,
+    size: Dp,
+    iconSize: Dp,
+    selected: Boolean,
+    hasNewItems: State<Boolean>?
+) {
     Box(remember { Modifier.size(size) }) {
         Icon(
             painter = painterResource(id = icon),
@@ -229,37 +170,36 @@ private fun NotifiableIcon(icon: Int, size: Dp, iconSize: Dp, selected: Boolean,
             tint = if (selected) MaterialTheme.colorScheme.primary else Color.Unspecified
         )
 
-        if (hasNewItems) {
-            Box(
-                remember {
+        if (hasNewItems?.value == true) {
+            NotificationDotIcon(
+                Modifier.align(Alignment.TopEnd)
+            )
+        }
+    }
+}
+
+@Composable
+private fun NotificationDotIcon(modifier: Modifier) {
+    Box(modifier.size(Size10dp)) {
+        Box(
+            modifier = remember {
+                Modifier
+                    .size(Size10dp)
+                    .clip(shape = CircleShape)
+            }.background(MaterialTheme.colorScheme.primary),
+            contentAlignment = Alignment.TopEnd
+        ) {
+            Text(
+                "",
+                color = Color.White,
+                textAlign = TextAlign.Center,
+                fontSize = 12.sp,
+                modifier = remember {
                     Modifier
-                        .width(10.dp)
-                        .height(10.dp)
+                        .wrapContentHeight()
                         .align(Alignment.TopEnd)
                 }
-            ) {
-                Box(
-                    modifier = remember {
-                        Modifier
-                            .width(10.dp)
-                            .height(10.dp)
-                            .clip(shape = CircleShape)
-                    }.background(MaterialTheme.colorScheme.primary),
-                    contentAlignment = Alignment.TopEnd
-                ) {
-                    Text(
-                        "",
-                        color = Color.White,
-                        textAlign = TextAlign.Center,
-                        fontSize = 12.sp,
-                        modifier = remember {
-                            Modifier
-                                .wrapContentHeight()
-                                .align(Alignment.TopEnd)
-                        }
-                    )
-                }
-            }
+            )
         }
     }
 }

app/src/main/java/com/vitorpamplona/amethyst/ui/note/BadgeCompose.kt

@@ -38,7 +38,6 @@ import com.vitorpamplona.amethyst.ui.screen.BadgeCard
 import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
 import com.vitorpamplona.amethyst.ui.theme.newItemBackgroundColor
 import com.vitorpamplona.amethyst.ui.theme.placeholderText
-import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 
 @OptIn(ExperimentalFoundationApi::class)
@@ -64,11 +63,7 @@ fun BadgeCompose(likeSetCard: BadgeCard, isInnerNote: Boolean = false, routeForL
         val newItemColor = MaterialTheme.colorScheme.newItemBackgroundColor
 
         LaunchedEffect(key1 = likeSetCard) {
-            scope.launch(Dispatchers.IO) {
-                val isNew = likeSetCard.createdAt() > accountViewModel.account.loadLastRead(routeForLastRead)
-
-                accountViewModel.account.markAsRead(routeForLastRead, likeSetCard.createdAt())
-
+            accountViewModel.loadAndMarkAsRead(routeForLastRead, likeSetCard.createdAt()) { isNew ->
                 val newBackgroundColor = if (isNew) {
                     newItemColor.compositeOver(defaultBackgroundColor)
                 } else {

app/src/main/java/com/vitorpamplona/amethyst/ui/note/ChannelCardCompose.kt

@@ -277,44 +277,38 @@ private fun CheckNewAndRenderChannelCard(
 ) {
     val newItemColor = MaterialTheme.colorScheme.newItemBackgroundColor
     val defaultBackgroundColor = MaterialTheme.colorScheme.background
-    val backgroundColor = remember { mutableStateOf<Color>(defaultBackgroundColor) }
+    val backgroundColor = remember {
+        mutableStateOf<Color>(
+            parentBackgroundColor?.value ?: defaultBackgroundColor
+        )
+    }
 
     LaunchedEffect(key1 = routeForLastRead, key2 = parentBackgroundColor?.value) {
-        launch(Dispatchers.IO) {
-            routeForLastRead?.let {
-                val lastTime = accountViewModel.account.loadLastRead(it)
-
-                val createdAt = baseNote.createdAt()
-                if (createdAt != null) {
-                    accountViewModel.account.markAsRead(it, createdAt)
-
-                    val isNew = createdAt > lastTime
-
-                    val newBackgroundColor = if (isNew) {
-                        if (parentBackgroundColor != null) {
-                            newItemColor.compositeOver(parentBackgroundColor.value)
-                        } else {
-                            newItemColor.compositeOver(defaultBackgroundColor)
-                        }
+        routeForLastRead?.let {
+            accountViewModel.loadAndMarkAsRead(routeForLastRead, baseNote.createdAt()) { isNew ->
+                val newBackgroundColor = if (isNew) {
+                    if (parentBackgroundColor != null) {
+                        newItemColor.compositeOver(parentBackgroundColor.value)
                     } else {
-                        parentBackgroundColor?.value ?: defaultBackgroundColor
-                    }
-
-                    if (newBackgroundColor != backgroundColor.value) {
-                        launch(Dispatchers.Main) {
-                            backgroundColor.value = newBackgroundColor
-                        }
+                        newItemColor.compositeOver(defaultBackgroundColor)
                     }
+                } else {
+                    parentBackgroundColor?.value ?: defaultBackgroundColor
                 }
-            } ?: run {
-                val newBackgroundColor = parentBackgroundColor?.value ?: defaultBackgroundColor
 
                 if (newBackgroundColor != backgroundColor.value) {
                     launch(Dispatchers.Main) {
                         backgroundColor.value = newBackgroundColor
                     }
                 }
             }
+        } ?: run {
+            val newBackgroundColor = parentBackgroundColor?.value ?: defaultBackgroundColor
+            if (newBackgroundColor != backgroundColor.value) {
+                launch(Dispatchers.Main) {
+                    backgroundColor.value = newBackgroundColor
+                }
+            }
         }
     }
 

app/src/main/java/com/vitorpamplona/amethyst/ui/note/ChatroomHeaderCompose.kt

@@ -415,9 +415,7 @@ private fun WatchNotificationChanges(
     accountViewModel: AccountViewModel,
     onNewStatus: (Boolean) -> Unit
 ) {
-    val cacheState by accountViewModel.accountLastReadLiveData.observeAsState()
-
-    LaunchedEffect(key1 = note, cacheState) {
+    LaunchedEffect(key1 = note, accountViewModel.accountMarkAsReadUpdates.value) {
         launch(Dispatchers.IO) {
             note.event?.createdAt()?.let {
                 val lastTime = accountViewModel.account.loadLastRead(route)

app/src/main/java/com/vitorpamplona/amethyst/ui/note/ChatroomMessageCompose.kt

@@ -73,8 +73,6 @@ import com.vitorpamplona.quartz.events.EmptyTagList
 import com.vitorpamplona.quartz.events.ImmutableListOfLists
 import com.vitorpamplona.quartz.events.PrivateDmEvent
 import com.vitorpamplona.quartz.events.toImmutableListOfLists
-import kotlinx.coroutines.Dispatchers
-import kotlinx.coroutines.launch
 
 @OptIn(ExperimentalFoundationApi::class)
 @Composable
@@ -260,12 +258,7 @@ fun NormalChatNote(
 
     if (routeForLastRead != null) {
         LaunchedEffect(key1 = routeForLastRead) {
-            launch(Dispatchers.IO) {
-                val createdAt = note.createdAt()
-                if (createdAt != null) {
-                    accountViewModel.account.markAsRead(routeForLastRead, createdAt)
-                }
-            }
+            accountViewModel.loadAndMarkAsRead(routeForLastRead, note.createdAt()) { }
         }
     }