Returning no Metadata if Metadata Spec is Empty #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atible because all metadata is fetched if the provided spec is null
Spiess
requested changes
Mar 3, 2022
Spiess
approved these changes
Mar 3, 2022
silvanheller
added a commit
that referenced
this pull request
Jun 10, 2022
* actually returning 0 results if spec is empty. This is backwards-compatible because all metadata is fetched if the provided spec is null Former-commit-id: 06a7812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be backward-compatible, the implementation of the
MetadataAccessSpecificationreturned all metadata if the field was not set in a query. However, the intention (and what this PR fixes) was that if an empty List is provided, no metadata is returned. This saves execution time for queries which do not care about metadata.