Fixing NearestNeighborRows only returning id column #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the id column, adding documentation
silvanheller
added a commit
that referenced
this pull request
Jun 10, 2022
Former-commit-id: fbc6c55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DBSelectorInterface had two abstractions for nearest-neighbor search, one of which only returns ids & distances, the other one returns the full row. The second one is used e.g by theAverageColorRasterFeature which has the schemaid,hist,rasterand requires the raster for score-computation.This PR fixes the cottontail implementation to avoid NPEs in
AverageColorRaster. Thanks to @benzvera for pointing out the bug.It also optimizes the
countDistinctValuescommand, which only needs to retrieve the column for which it counts distinct values.