-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/TensorFlow GPU #296
Conversation
Implemented build flag (-PGPU=true) to use TensorFlow GPU artefacts.
Have you tested that this is actually just a drop-in replacement and uses the GPU (e.g. using |
Please excuse, I forgot to mention that I did test this and could determine that the GPU is used, but since different item extractions are not batched, this could still be improved in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on ubuntu and can confirm it works. There is however not really any noticeable speedup for CLIP. One request: Could the jar have a flag indicating whether it was built with gpu support?
I think that would also make sense for the application build. Alternatively, we might just add a CLI command that lists the currently available GPU compute resources. That would also serve as a debug feature. |
# Conflicts: # gradle.properties
I just tried what happens if you include |
I removed the switch and set it directly to use the GPU-enabled dependency. We can merge this now. |
Former-commit-id: 062abb6
Implements additional build flag
-PGPU=true
to use GPU version of TensorFlow.Closes #293.
Will be made concrete once #294 is merged.