Making decorator for text retrieval configurable #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r cottontail writer
lucaro
requested changes
Jul 25, 2022
cineast-core/src/main/java/org/vitrivr/cineast/core/features/ProvidedOcrSearch.java
Outdated
Show resolved
Hide resolved
...st-core/src/main/java/org/vitrivr/cineast/core/features/abstracts/AbstractTextRetriever.java
Outdated
Show resolved
Hide resolved
|
I've made changes to all features which were using a specific type of map in their constructor and did not need it. |
lucaro
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, each term used to be decorated with
~at the end for fuzzy matches. This got lost at some point, which leads to a query forJAMESto not matchAMESin an OCR column. To fix this, this PR adds configurable decorators for all text-retrieval classes. Default behavior stays the same.Additionally, it adds the option to configure entity-names for text retrieval classes and fixes rare edge-cases where batch-import would cause problems.