Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual-Text Co-Embedding image retrieval #329

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

Spiess
Copy link
Member

@Spiess Spiess commented Jul 26, 2022

Previously the visual-text co-embedding only allowed retrieval with text terms and would even retrieve using the empty string provided by default if no text term was specified.
This has been fixed with appropriate error messages and returns.
Retrieval using image terms was implemented.

Previously the visual-text co-embedding only allowed retrieval with text terms and would even retrieve using the empty string provided by default if no text term was specified.
This has been fixed with appropriate error messages and returns.
Retrieval using image terms was implemented.
Copy link
Member

@silvanheller silvanheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvanheller silvanheller merged commit 1e7aea5 into main Jul 26, 2022
@silvanheller silvanheller deleted the feature/co-embedding-image-retrieval branch July 26, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants