Reworking Boolean Query Configuration Options #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauterl
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Code looks good to me. I do not really undestand why boolean-query-option.model.ts is an enum with values (1 and 2) and the values (aside from the enum itself) got removed for ValueType in bool-attributes.ts. This is a minor detail though.
Thanks for your work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue which was caused due to a recent Cottontail Update, where Integer-Dropdowns would return 0 results because they were sent as strings to Cottontail (and Cottontail doesn't parse Strings in queries as integers anymore if the column which is queried is an integer).
It adds significantly more configuration options to boolean terms (and removes redundancies), allows setting operators explicitly and makes the config more readable. All options are documented via examples in the default configuration. Additionally, vitrivr/cineast#286 adds a working Boolean retrieval for Segment IDs to the default to have an out-of-the-box example.
Additionally, this PR hides information about the stage-index unless there are multiple stage. For a visual diff:
Previously
Now