This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently break if non-asci chars (eg. März) are supplied
skel can also be a RelSkel - which is no subclass of Skeleton, so the super() call will fail
Replaced str() with unicode() in bone/dateBone:fromClient
Fixed a type-mismatch in renders/html/default:edit Approved-by: codepilot Approved-by: Andreas Kelch Approved-by: Stefan Kögl
…singSkel class Until now, for each referenced entry in any relation a new refSkel class was beeing created and assigned to valuesCache[boneName]["dest"]. Now, we're reusing a global refSkel class and assign only its valuesCache to our valuesCache[boneName]["dest"]. Warning: Break threadsafety in it's current form. We'll have to decide if we want to support it and adapt accordingly.
… an user without any access rights the possibility to logout and view himself.
…naviable for templates The values of "rel" had been dupplicated into "dest" if multiple=True and an using-skel is set.
Fixing the canAccess() functions of the admin- and vi-renders to give an user without any access rights the possibility to logout and view himself. Approved-by: Tobias Steinrücken <ts@mausbrand.de> Approved-by: Andreas H. Kelch <ak@mausbrand.de>
…ustom email services, like sendgrid.
…'s new value, not the skel-class instances
…to feature/fastRelations
anyway, I found out that skel["key"] always works to set an skeleton's key attribute, which is very awesome, so IMHO this key parameter can be entirely removed.
…e onItemDeleted() from the List-module sometimes depend on this value to perform further operations with the old (set to None!) key.. It must be available even after the entity has been deleted. The old server made it so.
…uld it always be invisible? This fixes it and keeps the existing behavior.
Fixing the order module. Approved-by: Andreas H. Kelch <ak@mausbrand.de> Approved-by: codepilot <jmm@phorward.de>
Feature/splitCommitCustomEmailHandler Approved-by: Andreas H. Kelch <ak@mausbrand.de> Approved-by: codepilot <jmm@phorward.de>
When a userBone with updatemagic or creationmagic is created, why should it always be invisible? This fixes it and keeps the existing behavior. Approved-by: Tobias Steinrücken <ts@mausbrand.de> Approved-by: Andreas H. Kelch <ak@mausbrand.de>
Don't set key to None when skeleton.delete() is called Approved-by: Andreas H. Kelch <ak@mausbrand.de> Approved-by: Tobias Steinrücken <ts@mausbrand.de>
Export "unique" property of bone structure in json renderer. Approved-by: codepilot <jmm@phorward.de> Approved-by: Tobias Steinrücken <ts@mausbrand.de> Approved-by: Andreas H. Kelch <ak@mausbrand.de>
Merge master back to develop
…rPassThrough Introduced the passThrough parameter to renders and unified the API of renders
…entFields serializing a textBone failed in getSearchDocumentFields if valuesCache[name] is None
Updated changelog.md to reflect latest merges
Bump version to 2.1.0 for release
…otimestamp() but our datebone class ExtendedDateTime does
fixed an import in env/date.py
This bug only came up when using a dateBone inside a RelSkel with ViUR 2.1. In ViUR 2.0, where it was previously developed with, the bug did not raise. This fixes the issue by simply returning None when no value is provided.
This commit should provide ways to export the new params-variable to provide additional information to the client. It is used by refactor_secondfactor. Tendering the XML-renderer anymore should be discussed soon.
Fixing the bug that comes up when a DB entry has no defaultValue and the value even is not set in the database, causing that it does not exist in the valuesCache.
Fixing bug in dateBone.serialize()
Bugfix for stringBone not existing in DB
Set maxint as max value to sortindex
Consequently provide the tpl parameter
Export params variables by json and xml renderer
This always came into the case "if len( tmpdata ) > 2:" below, because key.partition("$") always returns a 3-item tuple, but the structural logic was created to deal with the result of a split() function call.
Fixing baseBone.buildDBFilter()
tsteinruecken
requested review from
theVAX,
skoegl,
xnopasaranx,
phorward and
akelch
February 8, 2018 15:20
phorward
approved these changes
Feb 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it so!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Develop contains the 2.1 release, while master is still stuck on 2.0.3.
I simply forgot to merge it back..