This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
fromClient() function for passwordBone and some code refactoring #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return False | ||
|
|
||
| def fromClient( self, valuesCache, name, data ): |
There was a problem hiding this comment.
I think we can simplify that. Check for "not value" first (and return "No value entered" directly), and then test for isInvalid (return err) else store value.
With the current code, err is always False if no value is set; so the expression "not value and not err" can be shortened
There was a problem hiding this comment.
You're right, I've fixed it now and hope this fits your recommendations.
tsteinruecken
approved these changes
Apr 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a small enhancement for the passwordBone, including some code refactoring.