This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
Fixing problem that time "00:00:00" is passed #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the case when serializeForPost() is called with an empty date and with time=False, but a time is returned?
skoegl
approved these changes
Apr 15, 2019
phorward
added a commit
to viur-framework/server
that referenced
this pull request
Apr 15, 2019
Setting a date back to empty is not possible using fromClient right now: Empty string is converted to None, and None is not allowed by super-call to baseBone.isInvalid() as valid value. So this might fix the problem and integrates with [#32](viur-framework/viur-vi#32) in vi.
sveneberth
approved these changes
Apr 17, 2019
sveneberth
suggested changes
Apr 17, 2019
sveneberth
approved these changes
Apr 17, 2019
skoegl
pushed a commit
to viur-framework/server
that referenced
this pull request
Apr 26, 2019
Setting a date back to empty is not possible using fromClient right now: Empty string is converted to None, and None is not allowed by super-call to baseBone.isInvalid() as valid value. So this might fix the problem and integrates with [#32](viur-framework/viur-vi#32) in vi.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the case when serializeForPost() is called with an empty date and with time=False, but a time is returned?