Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIMX] [MLNX] Removed Platform specific reboot files for simx #22

Closed
wants to merge 1 commit into from

Conversation

vivekrnv
Copy link
Owner

@vivekrnv vivekrnv commented May 4, 2022

Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com

Why I did it

Platform_reboot files for simx doesn't do aything different apart from calling /sbin/reboot. which is anyway done in the /usr/local/bin/reboot script i.e. the parent script which calls the platform specific reboot scripts if present.

Moreover, /sbin/reboot invoked in the platform specific reboot script is a non-blocking call and thus it returns back to the original script (although /sbin/reboot does it job in the background) and we see messages like this.

Wed 04 May 2022 08:15:14 AM UTC Rebooting with platform x86_64-mlnx_msn2700_simx-r0 specific tool ...
Wed 04 May 2022 08:15:15 AM UTC Platform specific reboot failed!
Wed 04 May 2022 08:15:15 AM UTC Issuing OS-level reboot ...
admin@r-leopard-simx-69:~$ sudo reboot
.................................
................................
+ '[' -x /usr/share/sonic/device/x86_64-mlnx_msn4700_simx-r0/platform_reboot ']'
+ VERBOSE=yes
+ debug 'Rebooting with platform x86_64-mlnx_msn4700_simx-r0 specific tool ...'
+ [[ xyes == x\y\e\s ]]
++ date
+ echo Wed 04 May 2022 10:59:08 PM UTC Rebooting with platform x86_64-mlnx_msn4700_simx-r0 specific tool ...
Wed 04 May 2022 10:59:08 PM UTC Rebooting with platform x86_64-mlnx_msn4700_simx-r0 specific tool ...
+ logger 'Rebooting with platform x86_64-mlnx_msn4700_simx-r0 specific tool ...'
+ /usr/share/sonic/device/x86_64-mlnx_msn4700_simx-r0/platform_reboot
+ declare -r EXIT_SUCCESS=0
+ declare -r EXIT_ERROR=1
+ FORCE_REBOOT=no
+ ParseArguments
+ '[' 0 -ge 1 ']'
+ exec /sbin/reboot
+ sleep 1
+ VERBOSE=yes
+ debug 'Platform specific reboot failed!'
+ [[ xyes == x\y\e\s ]]
++ date
+ echo Wed 04 May 2022 10:59:09 PM UTC Platform specific reboot 'failed!'
Wed 04 May 2022 10:59:09 PM UTC Platform specific reboot failed!
+ logger 'Platform specific reboot failed!'
+ VERBOSE=yes
+ debug 'Issuing OS-level reboot ...'
+ [[ xyes == x\y\e\s ]]
++ date
+ echo Wed 04 May 2022 10:59:09 PM UTC Issuing OS-level reboot ...
Wed 04 May 2022 10:59:09 PM UTC Issuing OS-level reboot ...
+ logger 'Issuing OS-level reboot ...'
+ exec /sbin/reboot

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Copy link
Owner Author

vivekrnv commented May 4, 2022

@dgsudharsan, @liat-grozovik Please review

@vivekrnv vivekrnv closed this May 10, 2022
vivekrnv pushed a commit that referenced this pull request Aug 10, 2022
Changes:

Update submodule branch to 202012
[sonic-linkmgrd][202012] submodule update

a8ddff5 Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27)
a3f78a3 Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23)
05156fb Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22)
74529ef Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24)

sign-off: Jing Zhang zhangjing@microsoft.com
vivekrnv pushed a commit that referenced this pull request Dec 19, 2022
Added below commits:
9b30690 jcaiMR Fri Dec 16 fix handleSwssNotification crash in dhcp6relay (#28)
047afb7 jcaiMR Wed Dec 14 14:08:58 2022 +0800 Fix multiple vlan issue (#27)
ff6bec3 Vivek Thu Dec 8 09:44:15 2022 -0800 Made the Error log informative (#22)
2fbe729 jcaiMR Wed Nov 30 14:41:53 2022 +0800 disable cfg dynamic change (#25)
13d0805 Liu Shilong Wed Nov 30 10:54:11 2022 +0800 Use github code scanning instead of LGTM (#26)
1e846f6 kellyyeh Wed Nov 23 14:36:02 2022 -0800 Fix packet range check for relay-reply packets (#21)
4d19e13 kellyyeh Thu Nov 17 10:04:53 2022 -0800 Add unittest infrastructure (#5)
7f4fdab jcaiMR Fri Nov 11 14:47:51 2022 +0800 fix packet range check issue (#20)
257ecdf kellyyeh Thu Nov 3 11:34:11 2022 -0700 Add client packet UDP header length check (#19)
vivekrnv pushed a commit that referenced this pull request Mar 13, 2023


advance dhcp relay for 202211

4bf1868 - (HEAD, origin/master, origin/HEAD, master) fix relay-reply dhcpv6 packet counter issue (add support for a7050 qx32 platform #29) (2 weeks ago) [jcaiMR]
9b30690 - fix handleSwssNotification crash in dhcp6relay (Add libnl-nf-3-200 to docker-team #28) (4 weeks ago) [jcaiMR]
047afb7 - Fix multiple vlan issue (Failure trying to run: chroot /sonic-buildimage/fsroot mount -t proc proc /proc #27) (4 weeks ago) [jcaiMR]
ff6bec3 - Made the Error log informative (add python-tenjin as build dependency for p4-switch #22) (5 weeks ago) [Vivek]
2fbe729 - disable cfg dynamic change (p4: fix build dependency for python-p4c-bm #25) (6 weeks ago) [jcaiMR]
13d0805 - Use github code scanning instead of LGTM (Removed sx-libnl from Mellanox containers dependencies. #26) (6 weeks ago) [Liu Shilong]
1e846f6 - Fix packet range check for relay-reply packets (update sonic-swss and p4-switch submodule to fix docker sonic p4 bug #21) (7 weeks ago) [kellyyeh]
4d19e13 - Add unittest infrastructure (Cavium customization for docker containers #5) (8 weeks ago) [kellyyeh]
7f4fdab - fix packet range check issue (Makefile: add build dependency for python-p4c-bm #20) (9 weeks ago) [jcaiMR]
257ecdf - Add client packet UDP header length check (change port_config.ini directory for s6000 #19) (2 months ago) [kellyyeh]
vivekrnv pushed a commit that referenced this pull request Nov 7, 2023
Update the sonic-pins submodule. This brings in the following commit:

56a7762 Use json.hpp from nlohmann-json-dev instead of from swss-common (#22)

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
vivekrnv pushed a commit that referenced this pull request Aug 21, 2024
…tically (sonic-net#19550)

#### Why I did it
src/sonic-dash-api
```
* 1fd0b7d - (HEAD -> 202405, origin/202405) [202405 build] Update pool sonicbld to sonic-ububtu-1c since it's deprecated (#22) (11 days ago) [Jianquan Ye]
```
#### How I did it
#### How to verify it
#### Description for the changelog
vivekrnv pushed a commit that referenced this pull request Sep 20, 2024
…sonic-net#19155)

#### Why I did it
src/dhcpmon
```
* 099e148 - (HEAD -> 202311, origin/202311) Merge pull request #22 from yaqiangz/202311_cherry_pick (2 hours ago) [Ying Xie]
* efff8a9 - Fix revert (#21) (2 hours ago) [kellyyeh]
* 617066f - Revert DHCP Counter (#20) (2 hours ago) [kellyyeh]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants