Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable war deployment model (#197.1) #3839

Closed
wants to merge 7 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Feb 23, 2023

VIVO GitHub issue: #3034

See details on previous reverted PR: #197

What's new?

  • Moved Vitro.defaultNamespace and rootUser.emailAddress from runtime properties to context.xml.
  • Maven build command no longer requires settings.xml
  • Maven command no longer deploys artifact to Tomcat
  • VIVO home directory provisioned on startup if not exists.

How should this be tested?

Clone Vitro and VIVO and checkout feature branches VIVO-3034-psuedo-rebase

git clone --branch VIVO-3034-psuedo-rebase git@github.com:vivo-project/Vitro.git
git clone --branch VIVO-3034-psuedo-rebase git@github.com:vivo-project/VIVO.git

or

git clone git@github.com:vivo-project/Vitro.git
cd Vitro
checkout VIVO-3034-psuedo-rebase
cd ..
git clone git@github.com:vivo-project/VIVO.git
cd VIVO
checkout VIVO-3034-psuedo-rebase

Build Vitro

cd Vitro
mvn clean install

Build and run VIVO with Docker

cd VIVO
mvn clean package
docker-compose up

If not using Docker, copy the war file into Tomcat.

cp installer/webapp/target/vivo.war /usr/local/tomcat/webapps/ROOT.war

Check http://localhost:8080/

Interested parties

@VIVO-project/vivo-committers @chenejac

@ghost ghost force-pushed the VIVO-3034-psuedo-rebase branch 15 times, most recently from e649189 to c7ec2a9 Compare February 23, 2023 22:09
@ghost ghost force-pushed the VIVO-3034-psuedo-rebase branch from c7ec2a9 to 94a9351 Compare February 23, 2023 22:16
@ghost ghost marked this pull request as ready for review February 27, 2023 14:45
@ghost ghost linked an issue Feb 27, 2023 that may be closed by this pull request
chenejac
chenejac previously approved these changes Mar 1, 2023
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwelling it works for me. Please, double check two my comments.

installer/pom.xml Outdated Show resolved Hide resolved
@ghost ghost requested a review from chenejac March 1, 2023 14:14
Copy link
Contributor

@kaladay kaladay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runtime properties has some commented out code still using /usr/local.

See:

home/src/main/resources/config/default.runtime.properties:176:#OpenSocial.tokenKeyFile = /usr/local/vivo/data/shindig/openssl/securitytokenkey.txt
home/src/main/resources/config/default.runtime.properties:361:# harvester.location = /usr/local/vivo/harvester/

I think these should be updated to /opt/vivo paths.

@ghost ghost requested a review from kaladay March 3, 2023 14:45
@ghost ghost mentioned this pull request Mar 3, 2023
@chenejac
Copy link
Contributor

chenejac commented Mar 6, 2023

superseded by #3844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIVO-1443: Decouple VIVO build from installation
3 participants