Enable TinyMCE for fixed html pages #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
requested changes
Apr 4, 2024
There was a problem hiding this comment.
@litvinovg thanks for this contribution.
This is working only in the isolated Vitro instance.
There is a pageManagement--customDataScript.ftl in VIVO, please apply the similar changes there.
litvinovg
force-pushed
the
wysywig-editor-fixed-html-pages
branch
from
9e9e18c
to
499a21c
Compare
chenejac
previously approved these changes
Apr 11, 2024
There was a problem hiding this comment.
@litvinovg I have tested this, it is working as expected. I have posted one comment in the VIVO PR, but it will be resolved in the separate PR. I have review the code only of the second commit, and don't have any suggestion for improvement.
|
@litvinovg When I create a new fixed HTML content I see a basic text editor until I save and refresh the page, only then (when editing) rich text editor is shown. 
|
litvinovg
force-pushed
the
wysywig-editor-fixed-html-pages
branch
from
499a21c
to
5826b6e
Compare
|
@milospp I added fixes for the issue. Could you test it once again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
VIVO PR
What does this pull request do?
Enables TinyMCE editor for Fixed HTML field.
How should this be tested?
Additional information
Stacked on top of #452
Interested parties
@VIVO-project/vivo-committers