Skip to content

feat: add sub menus/categories #55

feat: add sub menus/categories

feat: add sub menus/categories #55

Triggered via pull request June 16, 2024 18:31
Status Success
Total duration 1m 24s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

6 warnings
this function has too many arguments (8/7): src/post.rs#L103
warning: this function has too many arguments (8/7) --> src/post.rs:103:5 | 103 | / pub fn new( 104 | | front_matter: FrontMatter, 105 | | excerpt: Option<String>, 106 | | content: String, ... | 111 | | ancestor_directories_names: Vec<String>, 112 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
comparison to empty slice: src/content.rs#L190
warning: comparison to empty slice --> src/content.rs:190:20 | 190 | if dir_index != "" { | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dir_index.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty = note: `#[warn(clippy::comparison_to_empty)]` on by default
assigning the result of `ToOwned::to_owned()` may be inefficient: src/config/markup.rs#L174
warning: assigning the result of `ToOwned::to_owned()` may be inefficient --> src/config/markup.rs:174:13 | 174 | target = "target=\"_blank\" ".to_owned(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"target=\"_blank\" ".clone_into(&mut target)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default
this `if` statement can be collapsed: src/content.rs#L190
warning: this `if` statement can be collapsed --> src/content.rs:190:17 | 190 | / if dir_index != "" { 191 | | if site 192 | | .settings 193 | | .create_index_for ... | 199 | | } 200 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 190 ~ if dir_index != "" && site 191 + .settings 192 + .create_index_for 193 + .contains(&dir_index.to_string()) { 194 + let key = dir_index.to_string(); 195 + let posts = indexes_to_create.entry(key).or_default(); 196 + posts.push(post); 197 + } |
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/