docs: add : and / completion #83
Annotations
13 warnings
this function has too many arguments (8/7):
src/post.rs#L139
warning: this function has too many arguments (8/7)
--> src/post.rs:139:5
|
139 | / pub fn new(
140 | | front_matter: FrontMatter,
141 | | excerpt: Option<String>,
142 | | content: String,
... |
147 | | ancestor_directories_names: Vec<String>,
148 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
comparison to empty slice:
src/content.rs#L281
warning: comparison to empty slice
--> src/content.rs:281:20
|
281 | if dir_index != "" {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dir_index.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
= note: `#[warn(clippy::comparison_to_empty)]` on by default
|
the following explicit lifetimes could be elided: 'a:
src/content.rs#L254
warning: the following explicit lifetimes could be elided: 'a
--> src/content.rs:254:27
|
254 | pub fn get_posts_per_tags<'a>(posts: &'a [Post]) -> HashMap<String, Vec<&'a Post>> {
| ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
254 - pub fn get_posts_per_tags<'a>(posts: &'a [Post]) -> HashMap<String, Vec<&'a Post>> {
254 + pub fn get_posts_per_tags(posts: &[Post]) -> HashMap<String, Vec<&Post>> {
|
|
unnecessary use of `to_string`:
src/content.rs#L245
warning: unnecessary use of `to_string`
--> src/content.rs:245:21
|
245 | slugify(tag.to_string())
| ^^^^^^^^^^^^^^^ help: use: `tag`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
= note: `#[warn(clippy::unnecessary_to_owned)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L195
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:195:13
|
195 | &post,
| ^^^^^ help: change this to: `post`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L75
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:75:9
|
75 | &site.settings.website_title.as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `site.settings.website_title.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L74
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:74:9
|
74 | &site.settings.author.as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `site.settings.author.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L73
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:73:9
|
73 | &site.settings.base_url.as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `site.settings.base_url.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/content.rs#L67
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/content.rs:67:9
|
67 | &site.settings.base_url.as_str(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `site.settings.base_url.as_str()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
assigning the result of `ToOwned::to_owned()` may be inefficient:
src/config/markup.rs#L174
warning: assigning the result of `ToOwned::to_owned()` may be inefficient
--> src/config/markup.rs:174:13
|
174 | target = "target=\"_blank\" ".to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"target=\"_blank\" ".clone_into(&mut target)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
this `if` statement can be collapsed:
src/content.rs#L281
warning: this `if` statement can be collapsed
--> src/content.rs:281:17
|
281 | / if dir_index != "" {
282 | | if site
283 | | .settings
284 | | .create_index_for
... |
290 | | }
291 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
281 ~ if dir_index != "" && site
282 + .settings
283 + .create_index_for
284 + .contains(&dir_index.to_string()) {
285 + let key = dir_index.to_string();
286 + let posts = indexes_to_create.entry(key).or_default();
287 + posts.push(post);
288 + }
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|