Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive tags #1522

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Case insensitive tags #1522

merged 4 commits into from
Sep 18, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Sep 15, 2023

Summary:

This PR changes the logic of the index class to capture the name of the tag with case preserved and save it as a "name" value in the tags index, and then converts it to lower case for usage in the references index itself. When a request is made to list all references in a document, the name is looked up in the tags index, and the original display name restored.

The extra lookup could be a small delay in very large and complex projects, but it's the only way to achieve this.

The changes to support this feature is kept entirely inside the index class, but it does require an index rebuild since the old index will be invalidated by the changes.

This PR also cleans up annotations in the Outline module.

Related Issue(s):

Closes #1313

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.2 Beta 1 milestone Sep 15, 2023
@vkbo vkbo linked an issue Sep 16, 2023 that may be closed by this pull request
@vkbo vkbo merged commit 16f57e4 into dev Sep 18, 2023
9 checks passed
@vkbo vkbo deleted the case_insensitive_tags branch September 18, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case insensitive tags
1 participant