Make it possible to re-order build settings #1591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR makes build settings definitions drag-and-drop-able in the Manuscript Build window. This required a bit of rewriting in the underlying data class.
Now, all builds are loaded as BuildSettings objects, rather than as Python dicts and unpacked in a BuildSettings object when requested by the user. Preserving them as dicts meant changes in added/deprecated values were not propagated unless they were actively edited, so this approach means they will be cleaned up by the unpack validation. The change was needed in order to save the order field for the numerical order in which each build settings definition appears on the GUI.
Related Issue(s):
Closes #1542
Reviewer's Checklist: