Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to re-order build settings #1591

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Make it possible to re-order build settings #1591

merged 1 commit into from
Nov 10, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 10, 2023

Summary:

This PR makes build settings definitions drag-and-drop-able in the Manuscript Build window. This required a bit of rewriting in the underlying data class.

Now, all builds are loaded as BuildSettings objects, rather than as Python dicts and unpacked in a BuildSettings object when requested by the user. Preserving them as dicts meant changes in added/deprecated values were not propagated unless they were actively edited, so this approach means they will be cleaned up by the unpack validation. The change was needed in order to save the order field for the numerical order in which each build settings definition appears on the GUI.

Related Issue(s):

Closes #1542

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.2 Beta 1 milestone Nov 10, 2023
@vkbo vkbo merged commit 062b336 into dev Nov 10, 2023
9 checks passed
@vkbo vkbo deleted the reorder_builds branch November 10, 2023 21:23
@vkbo vkbo linked an issue Nov 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reordering Compilation Settings
1 participant