Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements for 2.6 beta release #2095

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Minor improvements for 2.6 beta release #2095

merged 2 commits into from
Nov 13, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 12, 2024

Summary:

This PR:

  • Makes some improvements to the dialogue settings text in Preferences.
  • Moves the replacement of alternative apostrophe and horizontal bar Unicode symbols to later in the tokenization process. They are both available to prevent the dialogue highlighting from misunderstanding apostrophes and em-dashes, but now that dialogue highlighting is also processed in the viewer and manuscript build, they most be replaced after dialogue is detected, not before.

Related Issue(s):

Comment: #1773 (comment)

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6 RC 1 milestone Nov 12, 2024
@vkbo vkbo merged commit 5e7ef1d into main Nov 13, 2024
9 checks passed
@vkbo vkbo deleted the minor_improvements branch November 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant