Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor manuscript format text scaling #2102

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Refactor manuscript format text scaling #2102

merged 7 commits into from
Nov 13, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 13, 2024

Summary:

This PR fixes:

  • The DocX line height setting, which was correct in Libre Office, but not in Office 365. It does now scale to base font size, with an auto scaling for headers. This works in both office apps.
  • All ODT margins now scale to font size rather than font size and line height.
  • All HTML margins also scale directly to em.
  • Update default margin values so they produce roughly the same result as before.
  • Fix DocX page count so that it works in Office 365.
  • use icons for text margin and page size settings instead of single character labels.

Related Issue(s):

Closes #2098
Closes #2099

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo merged commit 1ee1912 into main Nov 13, 2024
9 checks passed
@vkbo vkbo deleted the format_scaling branch November 13, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Manuscript: docx applies extra line height to headings Build Settings: layout for Text Margins setting
1 participant