Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align headers to bottom of page margin for ODT and DocX #2128

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Align headers to bottom of page margin for ODT and DocX #2128

merged 2 commits into from
Nov 29, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 28, 2024 •
edited
Loading

Summary:

This PR changes how page headers in ODT and DocX documents are aligned. They are now approximately half a line above the top margin for both formats.

Related Issue(s):

Closes #2120

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6 Beta 2 milestone Nov 28, 2024
@vkbo vkbo merged commit 6502c42 into main Nov 29, 2024
9 checks passed
@vkbo vkbo deleted the doc_header_margins branch November 29, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.6 Beta 2
Development

Successfully merging this pull request may close these issues.

Page header position in docx compared to odt
1 participant
@vkbo