Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve editor auto-replace #2132

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Improve editor auto-replace #2132

merged 4 commits into from
Dec 5, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Dec 5, 2024

Summary:

This PR moves auto-replace into its own class. The new implementation is likely a minor improvement in the cases were only some auto-replace features are enabled, and should perform about the same in cases where many or all are in use. Mainly, it is just a refactoring to separate it from the main editor code and move all its associated class attributes.

Related Issue(s):

Related to #2129

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6 Beta 2 milestone Dec 5, 2024
@vkbo vkbo merged commit cc5cd50 into main Dec 5, 2024
9 checks passed
@vkbo vkbo deleted the auto_replace branch December 5, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant