Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor quoted dialogue detection #2138

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Refactor quoted dialogue detection #2138

merged 3 commits into from
Dec 23, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Dec 23, 2024 •
edited
Loading

Summary:

This PR updates quote-based dialogue detection to work better for Chinese quote style.

Related Issue(s):

Closes #2131

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6 Beta 2 milestone Dec 23, 2024
@vkbo vkbo merged commit f702155 into main Dec 23, 2024
9 checks passed
@vkbo vkbo deleted the quote_detection branch December 23, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.6 Beta 2
Development

Successfully merging this pull request may close these issues.

Dialogue highlighting works incorrectly with chinese grammer
1 participant
@vkbo