Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always adds --header "// Created {created}" to format command #19

Closed
jsonfry opened this issue Feb 11, 2022 · 4 comments
Closed

Always adds --header "// Created {created}" to format command #19

jsonfry opened this issue Feb 11, 2022 · 4 comments
Assignees
@vknabel
Labels
bug Something isn't working

Comments

@jsonfry
Copy link

jsonfry commented Feb 11, 2022

Looks like a recent change now always adds a file header on formatting

9f6af87
@vknabel vknabel self-assigned this Feb 11, 2022
@vknabel vknabel added the bug Something isn't working label Feb 11, 2022
vknabel added a commit that referenced this issue Feb 11, 2022
@vknabel
fix: accidentially always added --header "// Created {created}" #19
f3cf68d
@vknabel
Copy link
Owner

vknabel commented Feb 11, 2022

Thanks a lot @jsonfry!
Good catch! I committed some debugging code.

Just released a fix in v1.3.9. Sorry for the inconvenience!

@vknabel vknabel closed this as completed Feb 11, 2022
@jsonfry
Copy link
Author

jsonfry commented Feb 11, 2022

No worries, thanks for the quick fix!

@jsonfry
Copy link
Author

jsonfry commented Feb 14, 2022

Guten Morgen. I think something must have gone wrong with the release, it seems that code is still in the package you download from VS Marketplace

image

vknabel added a commit that referenced this issue Feb 14, 2022
@vknabel
fix: vsce publish didn't rebuild the extension #19
47eb0c1
@vknabel
Copy link
Owner

vknabel commented Feb 14, 2022

@jsonfry good morning, too! The vscode:prepublish-step to compile the project was missing. 😅
Should be fixed in 1.3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vknabel vknabel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsonfry @vknabel