Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nonzero exit codes as errors #49

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Handle nonzero exit codes as errors #49

merged 2 commits into from
Jul 3, 2024

Conversation

tristanlabelle
Copy link
Collaborator

@tristanlabelle tristanlabelle commented Jul 3, 2024 •
edited
Loading

Currently if swiftformat.exe returns a nonzero exit code, result.error is not populated so we proceed with formatting using the empty stdout.

After:
image

@tristanlabelle
Copy link
Collaborator Author

@vinocher-bc too

vinocher-bc
vinocher-bc approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@vinocher-bc vinocher-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this always returns a 0 status when the formatting succeeds.

@tristanlabelle tristanlabelle merged commit b36434b into main Jul 3, 2024
1 check passed
@tristanlabelle tristanlabelle deleted the handle-nonzero-exit-codes branch July 3, 2024 16:51
@tristanlabelle tristanlabelle mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinocher-bc vinocher-bc vinocher-bc approved these changes

@vknabel vknabel Awaiting requested review from vknabel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristanlabelle @vinocher-bc