Skip to content

Commit

Permalink
Fix 'for' param, add some tests #1610 (#1613)
Browse files Browse the repository at this point in the history
## Список изменений
- Исправлена ошибка с неуказанным For параметром (бесконечный мут)
- Добавлены тесты

##### Обязательно выполните следующие пункты:
- [x] Проверьте что ваш код не содержит конфликтов, и исправьте их по
необходимости
- [x] Напишите тесты, и обязательно проверьте что не падают другие.

##### Внимание! Pull Request'ы с непройденными тестами не принимаются
  • Loading branch information
xiadosw authored Mar 15, 2024
1 parent 7bf8a7b commit 179020d
Show file tree
Hide file tree
Showing 5 changed files with 57 additions and 3 deletions.
46 changes: 44 additions & 2 deletions VkNet.Tests/Categories/Messages/MessagesCategoryTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1122,10 +1122,10 @@ public void SetMemberRole()
}

[Fact]
public void ChangeConversationMemberRestrictions()
public void ChangeConversationMemberRestrictions_Mute()
{
Url = "https://api.vk.com/method/messages.changeConversationMemberRestrictions";
ReadCategoryJsonPath(nameof(ChangeConversationMemberRestrictions));
ReadCategoryJsonPath(nameof(ChangeConversationMemberRestrictions_Mute));

var response = Api.Messages.ChangeConversationMemberRestrictions(new()
{
Expand All @@ -1142,4 +1142,46 @@ public void ChangeConversationMemberRestrictions()
.BeEquivalentTo(new List<long> { 814412 });

}

[Fact]
public void ChangeConversationMemberRestrictions_MuteForever()
{
Url = "https://api.vk.com/method/messages.changeConversationMemberRestrictions";
ReadCategoryJsonPath(nameof(ChangeConversationMemberRestrictions_MuteForever));

var response = Api.Messages.ChangeConversationMemberRestrictions(new()
{
PeerId = 1,
MemberIds = new List<long>
{
814412, 4245645
},
Action = ConversationMemberRestrictionsActionType.Ro
});

response.FailedMemberIds.Should()
.BeEquivalentTo(new List<long> { 814412 });

}

[Fact]
public void ChangeConversationMemberRestrictions_Unmute()
{
Url = "https://api.vk.com/method/messages.changeConversationMemberRestrictions";
ReadCategoryJsonPath(nameof(ChangeConversationMemberRestrictions_Unmute));

var response = Api.Messages.ChangeConversationMemberRestrictions(new()
{
PeerId = 1,
MemberIds = new List<long>
{
4245645
},
Action = ConversationMemberRestrictionsActionType.Rw
});

response.FailedMemberIds.Should()
.BeEmpty();

}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"response": {
"failed_member_ids": [
814412
]
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"response": {
"failed_member_ids": []
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class MessagesChangeConversationMemberRestrictionsParams
/// Время в секундах. Если нужно замутить навсегда, то указывать не нужно.
/// </summary>
[JsonProperty("for", NullValueHandling = NullValueHandling.Ignore)]
public long For { get; set; }
public long? For { get; set; }

/// <summary>
/// Разрешенные действия.
Expand Down

0 comments on commit 179020d

Please sign in to comment.